lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Mar 2014 09:17:30 +0100 From: Heiko Carstens <heiko.carstens@...ibm.com> To: Dongsheng Yang <yangds.fnst@...fujitsu.com> Cc: linux-kernel@...r.kernel.org, joe@...ches.com, peterz@...radead.org, mingo@...nel.org, tglx@...utronix.de Subject: Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in prio.h. On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote: > This patch add a macro named NICE_TO_RLIMIT in prio.h to > convert nice value [19,-20] to rlimit style value [1,40]. > > Signed-off-by: Dongsheng Yang <yangds.fnst@...fujitsu.com> > --- > include/linux/sched/prio.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/sched/prio.h b/include/linux/sched/prio.h > index ac32258..8e78c47 100644 > --- a/include/linux/sched/prio.h > +++ b/include/linux/sched/prio.h > @@ -41,4 +41,9 @@ > #define TASK_USER_PRIO(p) USER_PRIO((p)->static_prio) > #define MAX_USER_PRIO (USER_PRIO(MAX_PRIO)) > > +/* > + * Convert nice value [19,-20] to rlimit style value [1,40]. > + */ > +#define NICE_TO_RLIMIT(nice) (MAX_NICE - nice + 1) Where is MAX_NICE defined? The s390 patch fails to compile. Also you probably want at least extra braces around the 'nice' usage to avoid subtle side effects. (or make NICE_TO.. a function, whatever). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists