linux-kernel - Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <531ECCD9.8050805@cn.fujitsu.com>
Date:	Tue, 11 Mar 2014 16:44:09 +0800
From:	Dongsheng Yang <yangds.fnst@...fujitsu.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
CC:	linux-kernel@...r.kernel.org, joe@...ches.com,
	peterz@...radead.org, mingo@...nel.org, tglx@...utronix.de
Subject: Re: [PATCH 01/15] sched/prio: Add a macro named NICE_TO_RLIMIT in
 prio.h.

On 03/11/2014 04:36 PM, Heiko Carstens wrote:
> On Tue, Mar 11, 2014 at 04:20:24PM +0800, Dongsheng Yang wrote:
>> On 03/11/2014 04:17 PM, Heiko Carstens wrote:
>>> On Tue, Mar 11, 2014 at 12:59:16PM +0800, Dongsheng Yang wrote:
>>>> +#define NICE_TO_RLIMIT(nice)	(MAX_NICE - nice + 1)
>>> Where is MAX_NICE defined? The s390 patch fails to compile.
>> MAX_NICE is defined in include/linux/sched/prio.h. It is applied in
>> tip tree, and not in mainline yet.
> Ok.
>
>>> Also you probably want at least extra braces around the 'nice' usage to
>>> avoid subtle side effects. (or make NICE_TO.. a function, whatever).
>> Yes, agree. Another question is that I am not sure when I need to
>> use a macro and when I should use a inline function.
>>
>> Could you help to give me some sugguestion?
> You can ask three people and get five opinions ;)

Hehe :)
>
> However if your above define would have been an inline function it
> wouldn't suffer from possible subtle side effects and it would have
> sane type checking etc.  So usually functions should be preferred.

I prefer to inline function too, it makes me feel more safe.

I will update this patch with an inline function.

Thanx
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/