linux-kernel - Re: [PATCH 02/16] kernel/sys: Replace opened code implementation with nice_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311092608.GT9987@twins.programming.kicks-ass.net>
Date:	Tue, 11 Mar 2014 10:26:08 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Dongsheng Yang <yangds.fnst@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, joe@...ches.com, mingo@...nel.org,
	tglx@...utronix.de, heiko.carstens@...ibm.com,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Robin Holt <holt@....com>, Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 02/16] kernel/sys: Replace opened code implementation
 with nice_to_rlimit().

On Tue, Mar 11, 2014 at 05:20:23PM +0800, Dongsheng Yang wrote:
> From: Joe Perches <joe@...ches.com>
> 
> Convert 20 - task_nice(p) to nice_to_rlimit(task_nice(p)).
> 
> Reduce the indent the switch case labels while there.
> 
> git diff -w shows 3 lines changed and a /* fall-through */ comment added
> 
>   $ git diff -w -U0 kernel/sys.c
>   @@ -253 +253 @@ SYSCALL_DEFINE2(getpriority, int, which, int, who)
>   -                               niceval = 20 - task_nice(p);
>   +                       niceval = nice_to_rlimit(task_nice(p));
>   @@ -264 +264 @@ SYSCALL_DEFINE2(getpriority, int, which, int, who)
>   -                               niceval = 20 - task_nice(p);
>   +                       niceval = nice_to_rlimit(task_nice(p));
>   @@ -280 +280 @@ SYSCALL_DEFINE2(getpriority, int, which, int, who)
>   -                                       niceval = 20 - task_nice(p);
>   +                               niceval = nice_to_rlimit(task_nice(p));
>   @@ -1558 +1558 @@ static void k_getrusage(struct task_struct *p, int who, struct rusage *r)
>   -
>   +               /* fall-through */
> 

I would really like to see the whitespace changes separated. I can push
a scheduler related change into other subsystems, but massive surgery
like this should not come through the scheduler tree.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/