linux-kernel - Re: [PATCH] devicetree: bindings: gpio-davinic: fix documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZT_noz0JnSr02tXvW6cddHt8kdNbstkrbfSzvLn45PJg@mail.gmail.com>
Date:	Tue, 11 Mar 2014 11:21:57 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Prabhakar Lad <prabhakar.csengg@...il.com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>,
	Grygorii Strashko <grygorii.strashko@...com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH] devicetree: bindings: gpio-davinic: fix documentation

On Thu, Mar 6, 2014 at 6:58 AM, Prabhakar Lad
<prabhakar.csengg@...il.com> wrote:

> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
>
> This patch adds missing #gpio-cells and also adds a
> usage example for leds.
>
> Reported-by: Alexander Holler <holler@...oftware.de>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Thanks, patch applied.

Note:

> +  - second cell is used to specify optional parameters (unused)
(...)
> +               gpios = <&gpio 10 GPIO_ACTIVE_HIGH>;

So you're using the unused cell.

However it is maybe nice to put things like that in there as it
sort of documents the system so whatever.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/