linux-kernel - Re: "can't evaluate _CRS: 1" messages since b355cee [ACPI / resources: ignore invalid ACPI device resources]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3023989.nMBYR9I9r3@vostro.rjw.lan>
Date:	Tue, 11 Mar 2014 14:27:52 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	"Zhang, Rui" <rui.zhang@...el.com>
Cc:	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: "can't evaluate _CRS: 1" messages since b355cee [ACPI / resources: ignore invalid ACPI device resources]

On Tuesday, March 11, 2014 01:11:19 PM Zhang, Rui wrote:
> 
> > -----Original Message-----
> > From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> > Sent: Tuesday, March 11, 2014 9:23 PM
> > To: Zhang, Rui
> > Cc: Markus Trippelsdorf; linux-acpi@...r.kernel.org; Wysocki, Rafael J;
> > linux-kernel@...r.kernel.org
> > Subject: Re: "can't evaluate _CRS: 1" messages since b355cee [ACPI /
> > resources: ignore invalid ACPI device resources]
> > Importance: High
> > 
> > On Tuesday, March 11, 2014 12:59:47 PM Zhang, Rui wrote:
> > > I think the reason problem is that:
> > > 1. there are zero length IO/Memory resources for these machines, and
> > for those resources
> > >    a) w/o commit b355cee88e3b1a193f0e9a81db810f6f83ad728b,
> > acpi_dev_resource_memory/io returns true
> > >    b) w commit b355cee88e3b1a193f0e9a81db810f6f83ad728b,
> > > acpi_dev_resource_memory/io returns false 2. in
> > pnpacpi_allocated_resource(), when acpi_dev_resource_memory/io()
> > returns false, it translates into "the resource is not IO/Memory
> > resource".
> > >
> > > IMO, the root cause is that the BOOL return value of
> > > acpi_dev_resource_memory/io() can not represent the following three
> > > situations
> > > 1) a valid IO/Memory resource
> > > 2) an invalid IO/Memory resource
> > > 3) not an IO/Memory resource
> > 
> > Well, can we make acpi_dev_resource_memory/io return an int, then, so
> > that it can cover all of the cases it needs to cover correctly and so
> > that we can get rid of those confusing messages?
> > 
> Sure, I will submit a patch soon.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/