linux-kernel - Re: [PATCH] ASoC: simple-card: overwrite DAIFMT_MASTER of cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311132553.GR28112@sirena.org.uk>
Date:	Tue, 11 Mar 2014 13:25:53 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <Guangyu.Chen@...escale.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	kuninori.morimoto.gx@...esas.com, moinejf@...e.fr,
	Li.Xiubo@...escale.com, lgirdwood@...il.com,
	Jyri Sarha <jsarha@...com>
Subject: Re: [PATCH] ASoC: simple-card: overwrite DAIFMT_MASTER of
 cpu_dai->fmt

On Tue, Mar 11, 2014 at 08:54:32PM +0800, Nicolin Chen wrote:

Adding Jyri who's been looking at this as well but not added anyone else
working on simple-card so you might've missed his mails.

> It's pretty fair to do it for DAIFMT_INV since two dais might have differnt
> definitions in their drivers even though it'd be better to keep it same if
> we could.

No, that's not at all OK - anything that requires this is broken.  The
same DAI format should be usable by both ends of the link unless the
board itself is inverting one of the signals or something.

> Thus this patch fixes it by overwriting the DAIFMT_MASTER bit of cpu_dai->fmt
> with the one of codec_dai->fmt since we defined DAIFMT_MASTER basing on CODEC
> at the first place.

This seems closer to what I'd expect for something like this but it does
mean that any format settings on the CPU DAI will be ignored (rather
than say warning or something).  I'm not sure this is a bad thing
though, probably wants the binding documenting at least.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)