linux-kernel - Re: [PATCH v2] x86: Remove compat vdso support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwaWgb-hCfOf8Y_LA+ZAHpTFYU937XN=7T6SxDAdpPzcg@mail.gmail.com>
Date:	Mon, 10 Mar 2014 18:39:03 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	Stefani Seibold <stefani@...bold.net>,
	Andreas Brief <Andreas.Brief@...de-schwarz.com>,
	Martin Runge <Martin.Runge@...de-schwarz.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: [PATCH v2] x86: Remove compat vdso support

On Mon, Mar 10, 2014 at 6:03 PM, Andy Lutomirski <luto@...capital.net> wrote:
>
> This is a bit of an abuse of the no-breaking-userspace policy.

No it's not, because it won't be applied.

You need to fix it.

I'm not sure what goes wrong, since it *looks* like you handle the
"vdso_enabled" thing correctly, so I find it surprising that you say
that

    echo 0 >/proc/sys/abi/vsyscall32

makes it work, since it should be zero already, and that echo should
be a no-op. But maybe I'm missing something.

Maybe you can just fake the boot parameter and fix the OpenSuSE
breakage that way (presumably that "init" sees it if it's some
user-space setup thing), but I'd like to know why that "echo 0" works,
but just initializing it to zero does not?

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/