linux-kernel - Re: [PATCH 2/3] soc: keystone: add QMSS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5EE98053-31B8-4679-AAE2-4F026C61D1D4@codeaurora.org>
Date:	Tue, 11 Mar 2014 09:04:24 -0500
From:	Kumar Gala <galak@...eaurora.org>
To:	Santosh Shilimkar <santosh.shilimkar@...com>
Cc:	Rob Herring <robherring2@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Sandeep Nair <sandeep_n@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH 2/3] soc: keystone: add QMSS driver


On Mar 10, 2014, at 4:19 PM, Santosh Shilimkar <santosh.shilimkar@...com> wrote:

>>> +  -- reg-names         : Names for the above register regions. The name to be
>>> +                         used is as follows:
>>> +                         - "config" : Queue configuration region.
>>> +                         - "status" : Queue status RAM.
>>> +                         - "region" : Descriptor memory setup region.
>>> +                         - "push"   : Queue Management/Queue Proxy region.
>>> +                         - "pop"    : Queue Management/Queue Proxy region.
>>> +                         - "peek"   : Queue Peek region.
>> 
>> reg-names should be optional. Also you have the order different from
>> reg. Be consistent as to what is the correct order.
>> 
> We thought of using reg-names to remove the ordering to index
> the regs. So if we make the reg-names optional, then indexing
> by order will be used. We can do that.

We keep having this conversation, why does reg-names need to be optional for new bindings?

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/