linux-kernel - Re: [PATCH 1/3] Staging: comedi: Fix some raw printks with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531F1B76.6010608@mev.co.uk>
Date:	Tue, 11 Mar 2014 14:19:34 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Conrad Meyer <cemeyer@...edu>, Greg Kroah-Hartman <greg@...ah.com>
CC:	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()

On 2014-03-09 02:42, Conrad Meyer wrote:
> Brought to you with the help of sed and manual clean-up after.
>
>    $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \
>      addi-data/hwdrv_apci1500.c
>
> Since all of these printk()s were for invalid API inputs and most of
> them returned -EINVAL, I fixed the rest of them to return -EINVAL as
> well.
>
> Signed-off-by: Conrad Meyer <cse.cem@...il.com>

In comedi, we usually use dev->class_dev as the device for these sorts 
of messages.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/