linux-kernel - Re: [PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2413657.D5tXqSSMNL@zefy>
Date:	Tue, 11 Mar 2014 11:01 -0400
From:	Fred Akers <knivey@...ops.net>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	gregkh@...uxfoundation.org, hsweeten@...ionengravers.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: apci_1564: Fix long CamelCase function names

On Tuesday, March 11, 2014 02:31:07 PM Ian Abbott wrote:
> On 2014-03-09 07:26, Fred Akers wrote:
> > This patch fixes a few function names that are very long and are
> > not in the correct naming style
> > 
> > Signed-off-by: Fred Akers <knivey@...ops.net>
> > ---
> > 
> >   .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 62
> >   ++++++++++------------ drivers/staging/comedi/drivers/addi_apci_1564.c 
> >     | 16 +++---
> >   2 files changed, 36 insertions(+), 42 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> > b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c index
> > a31e115..cb426e7 100644
> > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
> > @@ -116,7 +116,7 @@ static unsigned int ui_InterruptData, ui_Type;
> > 
> >   /*
> >   +-----------------------------------------------------------------------
> >   -----+> 
> > -| Function   Name   : int i_APCI1564_ConfigDigitalInput                  
> >    | +| Function   Name   : int i_apci1564_di_config                     
> > |
> It would be nice to get rid of the silly i_, v_ prefixes as well!

I'll submit a V2 removing those prefixes. I'm working on doing similar renames 
on functions for the other files under the addi-data directory as well. I'll 
include those in the V2 patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/