linux-kernel - Re: [tip:core/locking] locking/mutexes: Modify the way optimistic spinners are queued

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311153344.GX27965@twins.programming.kicks-ass.net>
Date:	Tue, 11 Mar 2014 16:33:44 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jason Low <jason.low2@...com>
Cc:	mingo@...nel.org, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/locking] locking/mutexes: Modify the way optimistic
 spinners are queued

On Tue, Mar 11, 2014 at 08:24:20AM -0700, Jason Low wrote:
> On Tue, 2014-03-11 at 05:41 -0700, tip-bot for Jason Low wrote:
> 
> > diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
> > index e6d646b..82dad2c 100644
> > --- a/kernel/locking/mutex.c
> > +++ b/kernel/locking/mutex.c
> > @@ -403,9 +403,9 @@ __mutex_lock_common(struct mutex *lock, long state, unsigned int subclass,
> >  	if (!mutex_can_spin_on_owner(lock))
> >  		goto slowpath;
> >  
> > +	mcs_spin_lock(&lock->mcs_lock, &node);
> >  	for (;;) {
> >  		struct task_struct *owner;
> > -		struct mcs_spinlock  node;
> 
> Hi Peter, Ingo,
> 
> The "struct mcs_spinlock node" still needs to be moved to the beginning
> of __mutex_lock_common() right?

Crud; I thought I fixed that since you pointed that out the last time.

Anyway; later patches make the argument go away, so its a bisect fail at
worst, not sure that's worth fixing at this point :/

sorry about that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/