linux-kernel - Re: [PATCH v2 3/5] regulator: add bcm590xx regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 11:47:50 -0400
From:	Matt Porter <mporter@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Christian Daudt <bcm@...thebug.org>,
	Devicetree List <devicetree@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] regulator: add bcm590xx regulator driver

On Wed, Feb 19, 2014 at 01:52:32PM +0900, Mark Brown wrote:
> On Tue, Feb 18, 2014 at 06:17:10PM -0500, Matt Porter wrote:
> 
> > +static struct of_device_id bcm590xx_of_match[] = {
> > +	{ .compatible = "brcm,bcm59056-regs", },
> > +	{ }
> > +};
> 
> This looks pretty much OK however I am in general suspicious of MFDs
> that have subdevices like this in the DT - it doesn't seem like this is
> a reusable device which can appear anywhere else so you're pretty much
> just representing the way that Linux splits things up here rather than a
> reusable IP that can reasonably have a separate binding.
> 
> If you had a binding which did something like enumerate the individual
> IP blocks as individual devices that'd be more interesting, I could see
> for example that a different PMIC might have a different set of register
> compatible regulator IPs laid out.  It looks like that might be doable,
> but it's in no way essential.

Ok I dropped this for v3 in favor of using mfd_add_device() and having
the regulator driver reference the of_node from the parent device.

-Matt



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)