linux-kernel - Re: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140311155054.GL25092@beef>
Date:	Tue, 11 Mar 2014 11:50:54 -0400
From:	Matt Porter <mporter@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Christian Daudt <bcm@...thebug.org>,
	Devicetree List <devicetree@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tim Kryger <tim.kryger@...aro.org>
Subject: Re: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for
 bcm28155-ap

On Wed, Feb 19, 2014 at 01:44:58PM +0900, Mark Brown wrote:
> On Tue, Feb 18, 2014 at 06:17:12PM -0500, Matt Porter wrote:
> 
> > +			csr_reg: regulator@13 {
> > +				reg = <13>;
> > +				regulator-compatible = "csr";
> > +				regulator-min-microvolt = <860000>;
> > +				regulator-max-microvolt = <1440000>;
> > +			};
> 

> You should not be setting voltage ranges like this in a .dtsi - you've
> no idea if these voltage ranges are in fact valid for any given board so
> they can't be set safely.  In general I would not expect to see any
> configuration at all for regulators in an include file for the chip.

Agreed. I moved all constraints where they belong in the board-specific
dts.

Thanks,
Matt

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)