linux-kernel - Re: [RESEND] Fast TSC calibration fails with v3.14-rc1 and later

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 18:15:13 +0100
From:	Julian Wollrath <jwollrath@....de>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
	Lee@...utronix.de, Chun-Yi <jlee@...e.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [RESEND] Fast TSC calibration fails with v3.14-rc1 and later

Am Tue, 11 Mar 2014 14:56:41 +0100 (CET)
schrieb Thomas Gleixner <tglx@...utronix.de>:
> > Ok, via bisecting I found commit
> > 73f7d1ca32638028e3271f54616773727e2f9f26 (see below) to be the one
> > that introduced this regression.
> 
> Interesting. I have no idea what's going on. But maybe can the ACPI
> folks shed some light on it.

I have absolutely no idea, if it is the right thing to do and why it
works, but the patch below fixes the problem. Thank you for your help.


Cheers,
Julian Wollrath

>From 7664f495039d93adfce073e58840a46549904f04 Mon Sep 17 00:00:00 2001
From: Julian Wollrath <jwollrath@....de>
Date: Tue, 11 Mar 2014 18:05:43 +0100
Subject: [PATCH] Fix fast TSC calibration

Since commit 73f7d1ca32638028e3271f54616773727e2f9f26 the fast TSC calibration
failed on a Thinkpad X121e with an AMD E450 APU. Moving acpi_early_init() after
late_time_init() fixes this.

Signed-off-by: Julian Wollrath <jwollrath@....de>
---
 init/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/main.c b/init/main.c
index eb03090cdced..bf9d99148bd6 100644
--- a/init/main.c
+++ b/init/main.c
@@ -561,7 +561,6 @@ asmlinkage void __init start_kernel(void)
 	init_timers();
 	hrtimers_init();
 	softirq_init();
-	acpi_early_init();
 	timekeeping_init();
 	time_init();
 	sched_clock_postinit();
@@ -609,6 +608,7 @@ asmlinkage void __init start_kernel(void)
 	numa_policy_init();
 	if (late_time_init)
 		late_time_init();
+	acpi_early_init();
 	sched_clock_init();
 	calibrate_delay();
 	pidmap_init();
-- 
1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/