linux-kernel - Re: [PATCH 3/8] perf, tools: Add --branch-history option to report v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140311202149.GS22728@two.firstfloor.org>
Date:	Tue, 11 Mar 2014 21:21:49 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...hat.com,
	mingo@...nel.org, linux-kernel@...r.kernel.org, eranian@...gle.com,
	namhyung@...nel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 3/8] perf, tools: Add --branch-history option to report
 v2

On Tue, Mar 11, 2014 at 04:25:02PM +0100, Jiri Olsa wrote:
> On Tue, Mar 11, 2014 at 01:31:54AM +0100, Andi Kleen wrote:
> > > this is *same* as parse_branch_mode function and seems to be not needed,
> > > I think both branch-stack and branch-history options could be handled
> > > by OPT_BOOLEAN
> > 
> > They can't because the type checker requires bool, and these variables
> > are tristate (UNSET, TRUE, FALSE)
> > 
> > -Andi
> 
> hum, I can see only 2 states there (please check patch below).. what do I miss?

-1 means undefined. Your patch changes things that the override would
happen even if the user explicitely set these options. It's not
equivalent.


-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/