linux-kernel - Re: mmotm 2014-03-10-15-35 uploaded (virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311214014.GA18708@leaf>
Date:	Tue, 11 Mar 2014 14:40:14 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Randy Dunlap <rdunlap@...radead.org>, mm-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-fsdevel@...r.kernel.org, linux-next@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	virtio-dev@...ts.oasis-open.org,
	"Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: mmotm 2014-03-10-15-35 uploaded (virtio_balloon)

On Tue, Mar 11, 2014 at 12:31:33PM -0700, Andrew Morton wrote:
> On Tue, 11 Mar 2014 12:20:46 -0700 Josh Triplett <josh@...htriplett.org> wrote:
> 
> > > > ERROR: "balloon_devinfo_alloc" [drivers/virtio/virtio_balloon.ko] undefined!
> > > > ERROR: "balloon_page_enqueue" [drivers/virtio/virtio_balloon.ko] undefined!
> > > > ERROR: "balloon_page_dequeue" [drivers/virtio/virtio_balloon.ko] undefined!
> > > > 
> > > > when loadable module
> > > > 
> > > > or
> > > > 
> > > > virtio_balloon.c:(.text+0x1fa26): undefined reference to `balloon_page_enqueue'
> > > > virtio_balloon.c:(.text+0x1fb87): undefined reference to `balloon_page_dequeue'
> > > > virtio_balloon.c:(.text+0x1fdf1): undefined reference to `balloon_devinfo_alloc'
> > > > 
> > > > when builtin.
> > > 
> > > OK, thanks, I'll drop
> > > http://ozlabs.org/~akpm/mmots/broken-out/mm-disable-mm-balloon_compactionc-completely-when-config_balloon_compaction.patch
> > 
> > Sorry about that; I missed that case in my testing.  It always seems
> > strange that the dependency goes that way around.
> > 
> > With virtio-balloon being the one and only user of this API, would it be
> > reasonable to just only compile in balloon_compaction.o when
> > CONFIG_VIRTIO_BALLOON?
> 
> Better to make VIRTIO_BALLOON depend on (or select) BALLOON_COMPACTION.

I'd love to do that, but as far as I can tell, VIRTIO_BALLOON has gone
out of its way to support !CONFIG_BALLOON_COMPACTION.

Could someone who works on VIRTIO_BALLOON provide some details here
about the distinction?

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/