linux-kernel - Re: [PATCH 2/5] resources: Set type in __request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo5EX0eZRAoff=wN7K3oSiF_mYMgTjLe-uPKXGUngG35aA@mail.gmail.com>
Date:	Tue, 11 Mar 2014 16:06:12 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Paul Bolle <pebolle@...cali.nl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] resources: Set type in __request_region()

On Tue, Mar 11, 2014 at 3:44 PM, Yinghai Lu <yinghai@...nel.org> wrote:
> On Tue, Mar 11, 2014 at 10:42 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
>> We don't set the type (I/O, memory, etc.) of resources added by
>> __request_region(), which leads to confusing messages like this:
>>
>>     address space collision: [io  0x1000-0x107f] conflicts with ACPI CPU throttle [??? 0x00001010-0x00001015 flags 0x80000000]
>>
>> Set the type of a new resource added by __request_region() (used by
>> request_region() and request_mem_region()) to the type of its parent.  This
>> makes the resource tree internally consistent and fixes messages like the
>> above, where the ACPI CPU throttle resource really is an I/O port region,
>> but request_region() didn't fill in the type, so %pR didn't know how to
>> print it.
>>
>> Sample dmesg showing the issue at the link below.
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=71611
>> Reported-by: Paul Bolle <pebolle@...cali.nl>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
>> ---
>>  kernel/resource.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/resource.c b/kernel/resource.c
>> index a8344dda7049..ae1f742c860c 100644
>> --- a/kernel/resource.c
>> +++ b/kernel/resource.c
>> @@ -945,8 +945,8 @@ struct resource * __request_region(struct resource *parent,
>>         res->name = name;
>>         res->start = start;
>>         res->end = start + n - 1;
>> -       res->flags = IORESOURCE_BUSY;
>> -       res->flags |= flags;
>> +       res->flags = parent->flags;
>
> can we use (parent->flags & IORESOURCE_TYPE_BITS) instead?

Yep, that seems like a good idea.  I changed it to:

+       res->flags = resource_type(parent);

Bjorn

>> +       res->flags |= IORESOURCE_BUSY | flags;
>>
>>         write_lock(&resource_lock);
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/