linux-kernel - Re: [PATCH v3 2/5] mfd: add bcm590xx pmu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311221938.GO25092@beef>
Date:	Tue, 11 Mar 2014 18:19:38 -0400
From:	Matt Porter <mporter@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Christian Daudt <bcm@...thebug.org>,
	Devicetree List <devicetree@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/5] mfd: add bcm590xx pmu driver

On Tue, Mar 11, 2014 at 04:08:37PM +0000, Lee Jones wrote:
> > Add a driver for the BCM590xx PMU multi-function devices. The driver
> > initially supports regmap initialization and instantiation of the
> > voltage regulator device function of the PMU.
> > 
> > Signed-off-by: Matt Porter <mporter@...aro.org>
> > Reviewed-by: Tim Kryger <tim.kryger@...aro.org>
> > Reviewed-by: Markus Mayer <markus.mayer@...aro.org>
> > ---
> >  drivers/mfd/Kconfig          |  8 ++++
> >  drivers/mfd/Makefile         |  1 +
> >  drivers/mfd/bcm590xx.c       | 93 ++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> >  4 files changed, 133 insertions(+)
> >  create mode 100644 drivers/mfd/bcm590xx.c
> >  create mode 100644 include/linux/mfd/bcm590xx.h
> 
> I have a tiny nit that 'ret' doesn't need to be initialised before
> use in probe(), but apart from that...
> 
> Looks pretty sensible:
>   Acked-by: Lee Jones <lee.jones@...aro.org>

Ok, thanks. When I get back in front of my desktop I'll send a v4 of
just this patch to address that nit. Mark already applied the regulator
driver from this series, will you be taking this through your tree? For
that matter, I wonder if the binding would also go through your tree
with this driver.

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/