linux-kernel - Re: [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 15:22:14 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	trivial@...nel.org, Chris Metcalf <cmetcalf@...era.com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Ken Steele <ken@...era.com>, Nicolas Pitre <nico@...aro.org>
Subject: Re: [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages

On Sat, Mar 8, 2014 at 11:14 AM, Paul Bolle <pebolle@...cali.nl> wrote:
> On Sat, 2014-03-08 at 10:58 -0800, Andy Lutomirski wrote:
>> Some of them are errors; some are not.  Annotate them accordingly.
>>
>> Signed-off-by: Andy Lutomirski <luto@...capital.net>
>> ---
>>  lib/raid6/algos.c | 13 +++++++------
>>  1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c
>> [...]
>> @@ -194,7 +195,7 @@ int __init raid6_select_algo(void)
>>       syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
>>
>>       if (!syndromes) {
>> -             printk("raid6: Yikes!  No memory available.\n");
>> +             printk(KERN_ERR "raid6: Yikes!  No memory available.\n");
>>               return -ENOMEM;
>>       }
>>
>
> Does __get_free_pages() print and error (or similar) when it fails? If
> so, this printk() could be dropped, couldn't it?

I think it does in warn_alloc_failed in mm/page_alloc.c.  It might not
be clear what the impact of that error is, but, empirically, if
there's too little memory during boot, everything is thoroughly broken
anyway.

>
>
> Paul Bolle
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/