| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Mar 2014 11:30:55 +0100
From: Boris BREZILLON <brezillonboris@...il.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
Nicolas Ferre <nicolas.ferre@...el.com>
Cc: Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
linux-arm-kernel@...ts.infradead.org, arm@...nel.org,
linux-kernel@...r.kernel.org,
Boris BREZILLON <b.brezillon.dev@...il.com>
Subject: [PATCH] net: macb: set interface name based on DT aliases
Use aliases to set the interface name (ethX) instead of automatic
assignement.
Signed-off-by: Boris BREZILLON <b.brezillon.dev@...il.com>
---
Hello Nicolas, Jean-Christophe,
This is an example on how we could set the ethernet interface id based on DT
aliases.
As you can see this patch is not properly separated.
I'm still not happy with this approach for several reasons:
1) If another ethernet iface has already been registered with the same id the
net dev registration will fail.
2) We bypass the ethernet macros/functions and directly use the net device
functions which IMHO is not future proof.
Best Regards,
Boris
arch/arm/boot/dts/sama5d36.dtsi | 2 +-
arch/arm/boot/dts/sama5d3_emac.dtsi | 4 ++++
arch/arm/boot/dts/sama5d3_gmac.dtsi | 4 ++++
drivers/net/ethernet/cadence/macb.c | 15 +++++++++++++--
4 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d36.dtsi b/arch/arm/boot/dts/sama5d36.dtsi
index 6c31c26..db58cad 100644
--- a/arch/arm/boot/dts/sama5d36.dtsi
+++ b/arch/arm/boot/dts/sama5d36.dtsi
@@ -8,8 +8,8 @@
*/
#include "sama5d3.dtsi"
#include "sama5d3_can.dtsi"
-#include "sama5d3_emac.dtsi"
#include "sama5d3_gmac.dtsi"
+#include "sama5d3_emac.dtsi"
#include "sama5d3_lcd.dtsi"
#include "sama5d3_mci2.dtsi"
#include "sama5d3_tcb1.dtsi"
diff --git a/arch/arm/boot/dts/sama5d3_emac.dtsi b/arch/arm/boot/dts/sama5d3_emac.dtsi
index fe2af92..f2c5da0 100644
--- a/arch/arm/boot/dts/sama5d3_emac.dtsi
+++ b/arch/arm/boot/dts/sama5d3_emac.dtsi
@@ -11,6 +11,10 @@
#include <dt-bindings/interrupt-controller/irq.h>
/ {
+ aliases {
+ eth1 = &macb1;
+ };
+
ahb {
apb {
pinctrl@...ff200 {
diff --git a/arch/arm/boot/dts/sama5d3_gmac.dtsi b/arch/arm/boot/dts/sama5d3_gmac.dtsi
index a6cb050..05164de 100644
--- a/arch/arm/boot/dts/sama5d3_gmac.dtsi
+++ b/arch/arm/boot/dts/sama5d3_gmac.dtsi
@@ -11,6 +11,10 @@
#include <dt-bindings/interrupt-controller/irq.h>
/ {
+ aliases {
+ eth0 = &macb0;
+ };
+
ahb {
apb {
pinctrl@...ff200 {
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 3190d38..b6f1f7c 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1795,7 +1795,7 @@ static int __init macb_probe(struct platform_device *pdev)
{
struct macb_platform_data *pdata;
struct resource *regs;
- struct net_device *dev;
+ struct net_device *dev = NULL;
struct macb *bp;
struct phy_device *phydev;
u32 config;
@@ -1819,7 +1819,18 @@ static int __init macb_probe(struct platform_device *pdev)
}
err = -ENOMEM;
- dev = alloc_etherdev(sizeof(*bp));
+ if (pdev->dev.of_node) {
+ int id = of_alias_get_id(pdev->dev.of_node, "eth");
+ if (id >= 0) {
+ char name[IFNAMSIZ];
+ snprintf(name, sizeof(name), "eth%d", id);
+ dev = alloc_netdev(sizeof(*bp), name, ether_setup);
+ }
+ }
+
+ if (!dev)
+ dev = alloc_etherdev(sizeof(*bp));
+
if (!dev)
goto err_out;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists