[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACVXFVM24tARya-yVfH1gB35jKFPP1nNnYf7EAirr0=wsWjs1Q@mail.gmail.com>
Date: Wed, 12 Mar 2014 19:27:14 +0800
From: Ming Lei <tom.leiming@...il.com>
To: Alexander Gordeev <agordeev@...hat.com>
Cc: Kent Overstreet <kmo@...erainc.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Peter Zijlstra <peterz@...radead.org>,
Jens Axboe <axboe@...nel.dk>,
"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Subject: Re: [PATCH RESEND 1/3] percpu_ida: Fix data race on cpus_have_tags cpumask
On Wed, Mar 12, 2014 at 12:31 AM, Alexander Gordeev <agordeev@...hat.com> wrote:
> On Tue, Mar 11, 2014 at 11:34:21PM +0800, Ming Lei wrote:
>> I mean the below block can be put inside the previous lock:
>
> Oh, *now* I see what you mean. Please, ignore my prevous reply.
> Still, we want to release the lock as soon as possible and
> there is no reason to the below bits it under lock.
Actually my comment was wrong because pool->cpus_have_tags
should be guarded by pool->lock instead of the percpu tag->lock.
Sorry for the noise.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists