linux-kernel - Re: [PATCH] sched: fix: remove double calculation in fix_small

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfTPtCjG-=6Uqo2jPr3xZytXDkT1K1oGycTLqMCcOHoOjYSvg@mail.gmail.com>
Date:	Wed, 12 Mar 2014 13:56:00 +0100
From:	Vincent Guittot <vincent.guittot@...aro.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...nel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: fix: remove double calculation in fix_small_imbalance

On 12 March 2014 10:00, Peter Zijlstra <peterz@...radead.org> wrote:
> On Tue, Mar 11, 2014 at 05:26:06PM +0100, Vincent Guittot wrote:
>> The tmp value has been already calculated in:
>> scaled_busy_load_per_task =
>>               (busiest->load_per_task * SCHED_POWER_SCALE) /
>>               busiest->group_power;
>
> You created a little confusion in my brain by saying it was a fix; while
> in fact it is an optimization removing duplicate computation.

sorry for the confusion.

>
> I've changed the Subject to read:
>
>   sched: Remove double calculation in fix_small_imbalance
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/