linux-kernel - Re: [PATCH 1/3] spi: add xtfpga SPI controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140312132427.GR28112@sirena.org.uk>
Date:	Wed, 12 Mar 2014 13:24:27 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Max Filippov <jcmvbkbc@...il.com>
Cc:	"linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>,
	linux-spi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Chris Zankel <chris@...kel.net>,
	Marc Gauthier <marc@...ence.com>,
	Rob Herring <robh+dt@...nel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/3] spi: add xtfpga SPI controller driver

On Wed, Mar 12, 2014 at 05:48:16AM +0400, Max Filippov wrote:
> On Wed, Mar 12, 2014 at 5:11 AM, Mark Brown <broonie@...nel.org> wrote:

> > So I just looked again - the SPI code isn't in mainline, there must
> > be some out of tree patches here that can't have been tested since the
> > driver was converted to regmap (or the byte swapping you're doing in the
> > controller is buggy for 16 bits per word).

> I'm successfully running this driver with the patches in your ASoC tree
> branch topic/tlv320aic23.

Ah, I missed that during review - the driver shouldn't be forcing 16
bits per word, any swapping that's needed should be being done in the
regmap API.  Though based on the discussion of the SPI driver it seems
like this may be compensating for an unwanted byte swap there.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)