linux-kernel - Re: [PATCH v4 1/5] mfd: add bcm590xx pmu DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140312134634.GR25092@beef>
Date:	Wed, 12 Mar 2014 09:46:34 -0400
From:	Matt Porter <mporter@...aro.org>
To:	Mark Rutland <mark.rutland@....com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Christian Daudt <bcm@...thebug.org>,
	Devicetree List <devicetree@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/5] mfd: add bcm590xx pmu DT binding

On Wed, Mar 12, 2014 at 01:33:39PM +0000, Mark Rutland wrote:
> On Tue, Mar 11, 2014 at 11:33:53PM +0000, Matt Porter wrote:
> > Add a DT binding for the BCM590xx PMUs. The binding inherits from
> > the generic regulator bindings.
> > 
> > Signed-off-by: Matt Porter <mporter@...aro.org>
> > Reviewed-by: Tim Kryger <tim.kryger@...aro.org>
> > Reviewed-by: Markus Mayer <markus.mayer@...aro.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/bcm590xx.txt | 41 ++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/bcm590xx.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/bcm590xx.txt b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
> > new file mode 100644
> > index 0000000..2300246
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
> > @@ -0,0 +1,41 @@
> > +-------------------------------
> > +BCM590xx Power Management Units
> > +-------------------------------
> > +
> > +Required properties:
> > +- compatible: "brcm,bcm59056"
> > +- reg: I2C slave address
> > +- interrupts: interrupt for the PMU. Generic interrupt client node bindings
> > +  are described in interrupt-controller/interrupts.txt
> 
> This all looks sane.
> 
> > +
> > +------------------
> > +Voltage Regulators
> > +------------------
> > +
> > +Optional properties:
> > +- regulators: This is the list of child nodes that specify the regulator
> > +  initialization data for defined regulators.  Generic regulator bindings
> > +  are described in regulator/regulator.txt.
> 
> This is a subnode, not a property. How about:
> 
> Optional child nodes:
> 
> - regulators: container node for regulators follwoing the generic
>   regulator binding in regulator/regulator.txt.

Agreed, I'll reword like that...makes more sense like that.

> > +
> > +  The valid regulator nodes for BCM59056 are:
> 
> s/nodes/node names/

Ok

> > +  	rfldo, camldo1, camldo2, simldo1, simldo2, sdldo, sdxldo,
> > +	mmcldo1, mmcldo2, audldo, micldo, usbldo, vibldo,
> > +	csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr
> > +
> > +Example:
> > +	pmu: bcm59056@8 {
> > +		compatible = "brcm,bcm59056";
> > +		reg = <0x08>;
> > +		interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
> > +		regulators {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			rfldo_reg: rfldo {
> > +				regulator-min-microvolt = <1200000>;
> > +				regulator-max-microvolt = <3300000>;
> 
> Are any specific properties required on these children?

None. The only requirement is that when regulator node exists, the
node names must match those listed.

I'll send out another version with rewording suggested above.

Thanks,
Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/