linux-kernel - Re: [PATCH 2/2] gpio: max732x: Fix possible NULL pointer dereference on i2c_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZEYWmhy6+027xp+6FdRO0RM+eVkf218Q+3HjjCWOSVOg@mail.gmail.com>
Date:	Wed, 12 Mar 2014 14:51:21 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: max732x: Fix possible NULL pointer dereference
 on i2c_new_dummy error

On Thu, Mar 6, 2014 at 10:31 AM, Krzysztof Kozlowski
<k.kozlowski@...sung.com> wrote:

> In max732x_probe() driver allocates dummy I2C device (if number of ports
> is greater than 8) with i2c_new_dummy() but it does not check the return
> value of this call.
>
> In case of error (i2c_new_device(): memory allocation failure or I2C
> address cannot be used) this function returns NULL which is later
> dereferenced by i2c_smbus_read_byte() (called from max732x_readb()).
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/