linux-kernel - Re: [PATCH] irq: Add a new IRQF_ACK_BEFORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1403122313250.18573@ionos.tec.linutronix.de>
Date:	Wed, 12 Mar 2014 23:16:38 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Hans de Goede <hdegoede@...hat.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Carlo Caione <carlo.caione@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH] irq: Add a new IRQF_ACK_BEFORE_UNMASK irq flag

On Wed, 12 Mar 2014, Hans de Goede wrote:
> This indeed seems the best solution. I'm going to send a v2
> of my sun4i irq patch-set with this patch included with 2 fixes added:
> 
> 1) Export the prototype for the new handle_fasteoi_late_irq function
> 2) Fix the minor issue Russell noticed
> 
> I've only one minor nitpick wrt this patch, for ONESHOT
> to work properly the irq_chip for an irq_desc using
> handle_fasteoi_late_irq must set the IRQCHIP_EOI_THREADED, but
> this is not enforced anywhere.
> 
> Maybe add a BUG_ON to the irq mapping code checking this ?

We want some info, but a BUG_ON is probably overkill. I'll think about
a good place to do this.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/