linux-kernel - Re: [PATCH 3/5] ARM: dts: exynos4x12: Add GPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Mar 2014 12:27:36 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Tomasz Figa <t.figa@...sung.com>
Cc:	kgene.kim@...sung.com, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com,
	rob.herring@...xeda.com, pawel.moll@....com, mark.rutland@....com,
	swarren@...dotorg.org, ijc+devicetree@...lion.org.uk,
	linux@....linux.org.uk
Subject: Re: [PATCH 3/5] ARM: dts: exynos4x12: Add GPS_ALIVE power domain

Hi Tomasz,

On 03/11/2014 09:28 PM, Tomasz Figa wrote:
> Hi Chanwoo,
> 
> On 11.03.2014 08:54, Chanwoo Choi wrote:
>> This patch add GPS_ALIVE power domain for Exynos4x12 SoC. GPS_ALIVE power domain
>> include GPS_BLK for GPS IP. Exynos SoC used generic power-domain driver to
>> control power domain. After completed kernel booting, Exynos power-domain driver
>> disable un-used power domain to reduce power-consumption/leak.
>>
>> If GPS_ALIVE power domain isn't registered to Exynos power-domain driver,
>> happen power-leakage because GPS_ALIVE_CONFIGURATION is default power on state.
>>
>> - 0x10023D00 : GPS_ALIVE_CONFIGURATION register address
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
>> ---
>>   arch/arm/boot/dts/exynos4x12.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
>> index 1ec77f6..066eb35 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -41,6 +41,11 @@
>>           compatible = "samsung,exynos4210-pd";
>>           reg = <0x10023CA0 0x20>;
>>       };
>> +   
>> +    pd_gps_alive: gps-alive-power-domain@...23D00 {
>> +        compatible = "samsung,exynos4210-pd";
>> +        reg = <0x10023D00 0x20>;
>> +    };
>>
> 
> Exynos4210 seems to have this power domain as well, so I guess this change should be done to exynos4.dtsi instead.
> 

You are right. I will modify it.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/