linux-kernel - RE: [f2fs-dev] [PATCH 3/5] f2fs: format segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <001801cf3e9c$ac3330d0$04999270$@samsung.com>
Date:	Thu, 13 Mar 2014 17:13:38 +0800
From:	Chao Yu <chao2.yu@...sung.com>
To:	'Gu Zheng' <guz.fnst@...fujitsu.com>,
	'Kim' <jaegeuk.kim@...sung.com>
Cc:	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'f2fs' <linux-f2fs-devel@...ts.sourceforge.net>
Subject: RE: [f2fs-dev] [PATCH 3/5] f2fs: format segment_info's show for better
	legibility

Hi Gu,

> -----Original Message-----
> From: Gu Zheng [mailto:guz.fnst@...fujitsu.com]
> Sent: Friday, March 07, 2014 6:44 PM
> To: Kim
> Cc: linux-kernel; f2fs
> Subject: [f2fs-dev] [PATCH 3/5] f2fs: format segment_info's show for better legibility
> 
> The original segment_info's show is a bit out-of-format:
> 
> [root@guz Demoes]# cat /proc/fs/f2fs/loop0/segment_info
> 0 0 0 0 0 0 0 0 0 0 0
> 0 0 0 0 0 0 0 0 0 0
> 0 0 0 0 0 0 0 0 0 0
> ......
> 0 0 0 0 0 0 0 0 0 0
> 0 0 1 0 0 1 [root@guz Demoes]#
> 
> so we fix it here for better legibility.
> [root@guz Demoes]# cat /proc/fs/f2fs/loop0/segment_info
> 0 0 0 0 0 0 0 0 0 0
> 0 0 0 0 0 0 0 0 0 0
> 0 0 0 0 0 0 0 0 0 0
> ......
> 0 0 0 0 0 0 0 0 0 0
> 0 0 1 0 0 1
> [root@guz Demoes]#

Here is one case, this looks not legible.

0 0 0 0 0 0 0 0 0 0
1 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 509 512 512 512
512 512 512 512 512 512 512 512 512 512
512 512 512 512 331 278 0 0 0 0
0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 512 512 512
512 512 512 512 512 512 512 512 512 512
0 512 512 512 512 512 512 1 0 512

So how about modifying code as following?

> 
> Signed-off-by: Gu Zheng <guz.fnst@...fujitsu.com>

Reviewed-by: Chao Yu <chao2.yu@...sung.com>

> ---
>  fs/f2fs/super.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 72df734..6e4851c 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -546,11 +546,12 @@ static int segment_info_seq_show(struct seq_file *seq, void *offset)
> 
>  	for (i = 0; i < total_segs; i++) {
>  		seq_printf(seq, "%u", get_valid_blocks(sbi, i, 1));

		seq_printf(seq, "%-3u ", get_valid_blocks(sbi, i, 1));

> -		if (i != 0 && (i % 10) == 0)
> -			seq_puts(seq, "\n");
> +		if ((i % 10) == 9 || i == (total_segs - 1))
> +			seq_putc(seq, '\n');
>  		else
> -			seq_puts(seq, " ");
> +			seq_putc(seq, ' ');
>  	}
> +
>  	return 0;
>  }
> 
> --
> 1.7.7
> 
> 
> ------------------------------------------------------------------------------
> Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
> With Perforce, you get hassle-free workflows. Merge that actually works.
> Faster operations. Version large binaries.  Built-in WAN optimization and the
> freedom to use Git, Perforce or both. Make the move to Perforce.
> http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/