linux-kernel - Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394708896.3577.21.camel@paszta.hi.pengutronix.de>
Date:	Thu, 13 Mar 2014 12:08:16 +0100
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Grant Likely <grant.likely@...aro.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Rob Herring <robh+dt@...nel.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org,
	Sylwester Nawrocki <s.nawrocki@...sung.com>
Subject: Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

Hi,

Am Montag, den 10.03.2014, 14:37 +0000 schrieb Grant Likely:
> > > Nak. I made comments that haven't been resolved yet. I've replied with
> > > more detail tonight. The big issues are how drivers handle the optional
> > > 'ports' node and I do not agree to the double-linkage in the binding
> > > description.

so as I understand it, nobody is against dropping the double-linkage
*if* we can agree on a way to recreate the backlinks in the kernel.
My current suggestion would be to parse the complete device tree into an
internal graph structure once, at boot to achieve this. This code could
look for the optional 'ports' node if and only if the parent device node
contains #address-cells != <1> or #size-cells != <0> properties.

People completely disagree about the direction the phandle links should
point in. I am still of the opinion that the generic binding should
describe just the topology, that the endpoint links in the kernel should
represent an undirected graph and the direction of links should not
matter at all for the generic graph bindings.

There's also no consensus about the simplified bindings, but this is an
issue I'd like to separate from this series.

> > If I understood well, you're requesting to revert all those six patches
> > that were imported via git pull from my tree (and from Greg and Russell),
> > right?
> > 
> > E. g. reverting those changesets:
> > 	d484700a3695 f2a575f67695 4329b93b283c 6ff60d397b17 4d56ed5a009b fd9fdb78a9bf
> > 
> > as it seems that there's no easy way to revert a git pull.
> 
> All trees containing the branch would need to be reverted.
>
> > I suspect that this will likely cause some harm when merging from our
> > trees upstream.
> 
> It means any tree containing that branch *must* be rewound. See my reply
> to rmk.

> I've made a proposal on how I could be happy with leaving the
> branches alone. I'm not particularly happy, but there is a way to
> resolve things without reverts or rewinds.

I'm not sure if maybe I misunderstood or missed a mail, but I haven't
seen a proposal to resolve the situation without rewinds. Given that
Mauro already reverted the media tree and applied conflicting changes,
that's probably not going to happen?

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/