linux-kernel - Re: [PATCH v2 2/3] mfd: sec-core: Add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1394714991.20773.5.camel@AMDC1943>
Date:	Thu, 13 Mar 2014 13:49:51 +0100
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Tomasz Figa <t.figa@...sung.com>, Lee Jones <lee.jones@...aro.org>
Cc:	Mike Turquette <mturquette@...aro.org>,
	linux-arm-kernel@...ts.infradead.org,
	Sangbeom Kim <sbkim73@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	Tushar Behera <tushar.behera@...aro.org>,
	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v2 2/3] mfd: sec-core: Add of_compatible strings for MFD
 cells

On Thu, 2014-03-13 at 13:37 +0100, Tomasz Figa wrote:
> On 13.03.2014 13:16, Krzysztof Kozlowski wrote:
> > On Thu, 2014-03-13 at 13:07 +0100, Tomasz Figa wrote:
> >> Hi Krzysztof,
> >>
> >> On 13.03.2014 10:37, Krzysztof Kozlowski wrote:
> >>> Add of_compatible strings for MFD cells for regulator, clock and RTC
> >>> drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> >>> ---
> >>>    drivers/mfd/sec-core.c |    8 ++++++++
> >>>    1 file changed, 8 insertions(+)
> >>>
> >>> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> >>> index d163c66edebb..c5b9b95b2099 100644
> >>> --- a/drivers/mfd/sec-core.c
> >>> +++ b/drivers/mfd/sec-core.c
> >>> @@ -55,28 +55,36 @@ static const struct mfd_cell s5m8763_devs[] = {
> >>>    static const struct mfd_cell s5m8767_devs[] = {
> >>>    	{
> >>>    		.name = "s5m8767-pmic",
> >>> +		.of_compatible = "samsung,s5m8767-regulators",
> >>>    	}, {
> >>>    		.name = "s5m-rtc",
> >>> +		.of_compatible = "samsung,s5m8767-rtc",
> >>>    	}, {
> >>>    		.name = "s5m8767-clk",
> >>> +		.of_compatible = "samsung,s5m8767-clk",
> >>>    	}
> >>>    };
> >>>
> >>>    static const struct mfd_cell s2mps11_devs[] = {
> >>>    	{
> >>>    		.name = "s2mps11-pmic",
> >>> +		.of_compatible = "samsung,s2mps11-regulators",
> >>>    	}, {
> >>>    		.name = "s2mps11-clk",
> >>> +		.of_compatible = "samsung,s2mps11-clk",
> >>>    	}
> >>>    };
> >>>
> >>>    static const struct mfd_cell s2mps14_devs[] = {
> >>>    	{
> >>>    		.name = "s2mps14-pmic",
> >>> +		.of_compatible = "samsung,s2mps14-regulators",
> >>>    	}, {
> >>>    		.name = "s2mps14-rtc",
> >>> +		.of_compatible = "samsung,s2mps14-rtc",
> >>>    	}, {
> >>>    		.name = "s2mps14-clk",
> >>> +		.of_compatible = "samsung,s2mps14-clk",
> >>>    	}
> >>>    };
> >>
> >> Are these compatible strings documented anywhere?
> >
> > The "-clk" compatible strings are (in next patch). The "-rtc" and
> > "-regulators" are not.
> 
> Hmm, this doesn't sound good.
> 
> > Actually they aren't also used by child driver (each child driver parses
> > from parent of_node).
> 
> Do you need to add compatible strings to mfd_cell entries of such cells 
> then?

>From my point of view there isn't any special need for them (except for
clk).

Dear Lee,

Do you wish to have these compatibles for all of child drivers even when
they aren't used directly by them? If yes then probably I should
document them.


Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/