linux-kernel - Re: [PATCH 13/18] dma: edma: Print the direction value as well when it is not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394715793.28803.240.camel@smile.fi.intel.com>
Date:	Thu, 13 Mar 2014 13:03:14 +0000
From:	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"joelf@...com" <joelf@...com>, Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	"nsekhar@...com" <nsekhar@...com>, Jyri Sarha <jsarha@...com>,
	"mporter@...aro.org" <mporter@...aro.org>,
	"Koul, Vinod" <vinod.koul@...el.com>,
	"Williams, Dan J" <dan.j.williams@...el.com>
Subject: Re: [PATCH 13/18] dma: edma: Print the direction value as well when
 it is not supported

On Thu, 2014-03-13 at 11:18 +0200, Peter Ujfalusi wrote:
> In case of not supported direction it is better to print the direction also.
> It is unlikely, but in such an event it helps with the debugging.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>  drivers/dma/edma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
> index 47abaac7eb18..69dd4e3de67e 100644
> --- a/drivers/dma/edma.c
> +++ b/drivers/dma/edma.c
> @@ -426,7 +426,7 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
>  		dev_width = echan->cfg.dst_addr_width;
>  		burst = echan->cfg.dst_maxburst;
>  	} else {
> -		dev_err(dev, "%s: bad direction?\n", __func__);
> +		dev_err(dev, "%s: bad direction: %d\n", __func__, direction);

Is it possible to have direction less than zero? Maybe %u?

>  		return NULL;
>  	}
>  
> @@ -519,7 +519,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
>  		dev_width = echan->cfg.dst_addr_width;
>  		burst = echan->cfg.dst_maxburst;
>  	} else {
> -		dev_err(dev, "%s: bad direction?\n", __func__);
> +		dev_err(dev, "%s: bad direction: %d\n", __func__, direction);

Ditto.

>  		return NULL;
>  	}
>  


-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.