linux-kernel - Re: [PATCH] staging: android: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140313135416.GB7083@laugharne.auvation.com>
Date:	Thu, 13 Mar 2014 13:54:17 +0000
From:	Mark Einon <mark@...on.net>
To:	mourn@...0fr.org
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	rebecca@...roid.com, john.stultz@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: fix coding style

I'll try that again...

On Thu, Mar 13, 2014 at 01:50:47PM +0000, Mark Einon wrote:
> On Thu, Mar 13, 2014 at 10:44:55AM +0100, mourn@...0fr.org wrote:
> > From: mourn <mourn@...0fr.org>
> > 
> > Signed-off-by: mourn <mourn@...0fr.org>
> > ---
> >  drivers/staging/android/uapi/ion.h |   12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 

The changes look good, however you should be a bit more specific about what the
fixes are, and that you used checkpatch.pl to find them (I assume).

Also, Signed-off-by: should state your full name, which I'm also assuming isn't
'mourn'. Please see Documentation/SubmittingPatches.

Cheers,

Mark


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/