[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABPqkBSSF3wUXsK-NPd83RPUEvOaJ3jcQuXbBpF7SdXwNtre2w@mail.gmail.com>
Date: Thu, 13 Mar 2014 20:35:43 +0100
From: Stephane Eranian <eranian@...gle.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Peter Zijlstra <peterz@...radead.org>,
"mingo@...e.hu" <mingo@...e.hu>,
"Yan, Zheng" <zheng.z.yan@...el.com>,
Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] perf/x86/uncore: fix missing end markers for SNB/IVB/HSW
IMC PMU
On Thu, Mar 13, 2014 at 6:17 PM, Andi Kleen <andi@...stfloor.org> wrote:
> Stephane Eranian <eranian@...gle.com> writes:
>
>> This patch fixes a bug with the SNB/IVB/HSW uncore
>> mmeory controller support.
>>
>> The PCI Ids tables for the memory controller were missing end markers.
>> That could cause random crashes on boot during or after PCI device
>> registration.
>
> I wonder if there's a way to check this in checkpatch.pl ?
>
> Or maybe a sparse check could be added, with a new type attribute
> that says "needs to be 0 terminate"
>
Not that easy , because in some cases, the size may be passed as a parameter
to the call or maybe embedded into a struct passed to the call.
But if you target this specific macro, you should be able to find the issues.
> -Andi
>
> --
> ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists