linux-kernel - Re: async_pf.c && use_mm() (Was: mm,vmacache: also flush cache for VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Mar 2014 14:44:28 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Gleb Natapov <gleb@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Davidlohr Bueso <davi@...hat.com>,
	Davidlohr Bueso <davidlohr@...com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Rik van Riel <riel@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>,
	Michel Lespinasse <walken@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: async_pf.c && use_mm() (Was: mm,vmacache: also flush cache for VM_CLONE)

On Thu, Mar 13, 2014 at 12:14 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> Maybe it uses use_mm just to increment the usage count. Which is bogus, and
> it should just "get" it instead, but whatever.
>
> On my phone, so I can't check the details.

Ok, no longer on my phone, and no, it clearly does the reference count with a

    atomic_inc(&work->mm->mm_count);

separately. The use_mm/unuse_mm seems entirely specious.

Maybe it has some historical meaning to it.

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/