linux-kernel - Re: [PATCH] mtip32xx: switch to vmalloc() to mitigate high order allocation failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 14 Mar 2014 00:48:03 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sam Bradshaw <sbradshaw@...ron.com>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	asamymuthupa@...ron.com
Subject: Re: [PATCH] mtip32xx: switch to vmalloc() to mitigate high order
 allocation failures

On Thu, 2014-03-13 at 15:57 -0700, Sam Bradshaw wrote:
> The mtip_port kmalloc() allocation is relatively high order, in
> particular since the recent doubling of the size of the scatterlist
> container.  The allocation has been shown to fail during SRSI under
> fragmented or low memory conditions.  Switching to vmalloc() mitigates
> the problem.  Converted both mtip_port and driver_data allocations for
> consistency.

It'd probably be better to use kmalloc and then
only if it fails use vmalloc.

See examples like net/sched/sch_hhf.c


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/