linux-kernel - Re: [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5322B91B.4020401@ti.com>
Date:	Fri, 14 Mar 2014 10:08:59 +0200
From:	Tero Kristo <t-kristo@...com>
To:	Joel Fernandes <joelf@...com>, Tony Lindgren <tony@...mide.com>,
	Rob Herring <robh@...nel.org>, Nishanth Menon <nm@...com>,
	Suman Anna <s-anna@...com>, Felipe Balbi <balbi@...com>
CC:	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 2/5] ARM: dts: am33xx: Set parent clock for timer through
 DT

On 03/13/2014 10:35 PM, Joel Fernandes wrote:
> Signed-off-by: Joel Fernandes <joelf@...com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 4e6c959..51b7008 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -352,6 +352,7 @@
>   			interrupts = <67>;
>   			ti,hwmods = "timer1";
>   			ti,timer-alwon;
> +			ti,default-parent = <&sys_clkin_ck>;
>   		};
>
>   		timer2: timer@...40000 {
> @@ -360,6 +361,7 @@
>   			reg = <0x48040000 0x400>;
>   			interrupts = <68>;
>   			ti,hwmods = "timer2";
> +			ti,default-parent = <&sys_clkin_ck>;
>   		};
>
>   		timer3: timer@...42000 {
>

I don't think this works, the ti,default-parent property is only 
supported for clock nodes (at least I didn't quickly find anything from 
your clocksource driver that would handle this.) You should do something 
like this:

&timer1_fck {
	ti,default-parent = <&sys_clkin_ck>;
};

&timer2_fck {
	ti,default-parent = <&sys_clkin_ck>;
};

-Tero

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/