linux-kernel - Re: [PATCH 1/1] block: rework flush sequencing for blk-mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5322D177.8050408@suse.de>
Date:	Fri, 14 Mar 2014 10:52:55 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Christoph Hellwig <hch@...radead.org>,
	Mike Snitzer <snitzer@...hat.com>
CC:	Jeff Moyer <jmoyer@...hat.com>, Jens Axboe <axboe@...nel.dk>,
	Shaohua Li <shli@...ionio.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] block: rework flush sequencing for blk-mq

On 03/14/2014 10:34 AM, Christoph Hellwig wrote:
> On Fri, Mar 14, 2014 at 02:25:19AM -0700, Christoph Hellwig wrote:
>> b) is a bit harder, but we should think hard about it when rewriting the
>> multipath code to support blk-mq.  Talking about which I think trying to
>> use dm-multipath on any blk-mq device will go horribly crash and boom at
>> the moment.
> 
> Talking abnout crashing and burning.. Hannes, did you run this patch
> past dm-devel and linux-scsi yet?  Don't quite like it but the problem
> seems real..
> 
No, I haven't. This issue is only exhibited if you try to run
multipath on a non-SCSI device (in this case it was cciss).
But then that project got abandoned, and there never was a machine
with a multipathed cciss controller.

Same issue with DASD; you _could_ potentially run multipath on DASD,
but all recent mainframes have a feature called 'hyperpav', which
essentially implements multipath support within the DASD driver. So
running multipath here won't buy you anything.
(Plus the DASD driver will only _ever_ return an I/O error
after is has had a response from the storage array.
Making it truly pointless to run multipathing ...)
The only valid use case would be xDR. But then RH apparently has
support for xDR even without that patch (otherwise they would have
asked for it, being the good upstream citizen as they claim to be,
right?) so it looks as if it's not needed there, neither.

So this patch hasn't had any application in the real world and
I haven't pursued with it upstream.

But if Mike feels it'll be a good idea nevertheless I can easily
send an updated version.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@...e.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/