linux-kernel - Re: [PATCH v2] gpio: davinci: fix gpio selection for OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5322F82A.9000507@ahsoftware.de>
Date:	Fri, 14 Mar 2014 13:38:02 +0100
From:	Alexander Holler <holler@...oftware.de>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Sekhar Nori <nsekhar@...com>,
	Prabhakar Lad <prabhakar.csengg@...il.com>
Subject: Re: [PATCH v2] gpio: davinci: fix gpio selection for OF

Am 14.03.2014 12:02, schrieb Linus Walleij:
> On Fri, Mar 14, 2014 at 11:08 AM, Alexander Holler <holler@...oftware.de> wrote:
>> Am 11.03.2014 11:15, schrieb Linus Walleij:
>>> On Wed, Mar 5, 2014 at 12:21 PM, Alexander Holler <holler@...oftware.de> wrote:
>>>
>>>> The driver missed an of_xlate function to translate gpio numbers
>>>> as found in the DT to the correct chip and number.
>>>>
>>>> While there I've set #gpio_cells to a fixed value of 2.
>>>>
>>>> I've used gpio-pxa.c as template for those changes and tested my changes
>>>> successfully on a da850 board using entries for gpio-leds in a DT. So I didn't
>>>> reinvent the wheel but just copied and tested stuff.
>>>>
>>>> Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa.
>>>>
>>>> Signed-off-by: Alexander Holler <holler@...oftware.de>
>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
>>>
>>> This v2 version applied, thanks!
>>
>> Thanks, but actually that should have been a fix for 3.14 with which the
>> OF functionality for davinci gpio gets introduced. I assum with the
>> patch in for-next, 3.14 will appear with that functionality broken and
>> it will become a candidate for -stable.
>
> I just get the impression that DT support for DaVinci in v3.14 is so risky
> and unstable that noone except those implementing it (i.e. you) is really
> using it, is that correct?

Yes. DT support for DaVinci is still incomplete and I don't think there 
are much people out there which already try to use it. Nevertheless is 
using DT a much easier way (and more future-proof) than patching 
board-files, if a board isn't one of those few supported dev-boards and 
needs different configurations.

> In that case it is hardly a fix that we need to rush out to the entire world.

Hmm, I think it's better to send something working and tested to world, 
than something untested and non-working.

And especially things like pinctrl and gpio are fundamental to even try 
to use DT. E.g. in my case I didn't even try to use DT for DaVinci 
because it doesn't make sense without support for DT in gpio. And now 
people will get promised but broken support for gpio in 3.14, which 
might cost a lot of time, if someone tries to use it.

And I thought the reason for -rc is actually to fix bugs. But I never 
understood the magical ways and timings patches make their way into 
mainline. ;)

Regards,

Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/