linux-kernel - Re: [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <53233AF8.9020501@samsung.com>
Date:	Fri, 14 Mar 2014 18:23:04 +0100
From:	Tomasz Figa <t.figa@...sung.com>
To:	Robert Baldyga <r.baldyga@...sung.com>, ben-linux@...ff.org,
	kgene.kim@...sung.com
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com
Subject: Re: [PATCH] ARM: dts: exynos4210-trats: add max8997 IRQ

Hi Robert,

On 14.03.2014 11:13, Robert Baldyga wrote:
> This patch adds device tree node for IRQ used by max8997.
>

Generally, this patch does not add just a node, but rather "IRQ line 
specification for the MAX8997 PMIC chip and necessary pinctrl group to 
configure pull-up and driver strength of the pin".

Also it would be nice to mention a reason for this change, e.g. what can 
be achieved after applying this patch.

Otherwise looks good.

Reviewed-by: Tomasz Figa <t.figa@...sung.com>

--
Best regards,
Tomasz

> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>
> ---
>   arch/arm/boot/dts/exynos4210-trats.dts |   13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index 1d18428..0e1fc19 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -148,6 +148,14 @@
>   		};
>   	};
>
> +	pinctrl@...00000 {
> +		max8997_irq: max8997-irq {
> +			samsung,pins = "gpx0-7";
> +			samsung,pin-pud = <3>;
> +			samsung,pin-drv = <0>;
> +		};
> +	};
> +
>   	i2c@...90000 {
>   		samsung,i2c-sda-delay = <100>;
>   		samsung,i2c-slave-addr = <0x10>;
> @@ -179,6 +187,11 @@
>   		max8997_pmic@66 {
>   			compatible = "maxim,max8997-pmic";
>
> +			pinctrl-0 = <&max8997_irq>;
> +			pinctrl-names = "default";
> +
> +			interrupt-parent = <&gpx0>;
> +			interrupts = <7 0>;
>   			reg = <0x66>;
>
>   			max8997,pmic-buck1-uses-gpio-dvs;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/