linux-kernel - Re: [PATCH] iio: force snprintf for PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53246799.8080600@kernel.org>
Date:	Sat, 15 Mar 2014 14:45:45 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
CC:	linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: force snprintf for PAGE_SIZE bufs

On 13/03/14 16:46, Kees Cook wrote:
> This is a tiny preventative measure to make sure we can't write beyond
> PAGE_SIZE on the buffers being used in sysfs for iio. There is currently
> no way for this to happen, but the change makes this code more robust
> for the future.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
A sensible enough change I guess.

Applied to the togreg branch of iio.git

Jonathan
> ---
>   drivers/iio/industrialio-core.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index acc911a836ca..64bb64f35af8 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -340,7 +340,7 @@ ssize_t iio_enum_read(struct iio_dev *indio_dev,
>   	else if (i >= e->num_items)
>   		return -EINVAL;
>
> -	return sprintf(buf, "%s\n", e->items[i]);
> +	return snprintf(buf, PAGE_SIZE, "%s\n", e->items[i]);
>   }
>   EXPORT_SYMBOL_GPL(iio_enum_read);
>
> @@ -836,7 +836,7 @@ static ssize_t iio_show_dev_name(struct device *dev,
>   				 char *buf)
>   {
>   	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> -	return sprintf(buf, "%s\n", indio_dev->name);
> +	return snprintf(buf, PAGE_SIZE, "%s\n", indio_dev->name);
>   }
>
>   static DEVICE_ATTR(name, S_IRUGO, iio_show_dev_name, NULL);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/