[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140315022707.GB22728@two.firstfloor.org>
Date: Sat, 15 Mar 2014 03:27:07 +0100
From: Andi Kleen <andi@...stfloor.org>
To: David Ahern <dsahern@...il.com>
Cc: Andi Kleen <andi@...stfloor.org>, acme@...radead.org,
mingo@...nel.org, linux-kernel@...r.kernel.org,
peterz@...radead.org, eranian@...gle.com, namhyung@...nel.org,
jolsa@...hat.com, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 01/10] perf, tools: Add jsmn `jasmine' JSON parser
On Fri, Mar 14, 2014 at 04:41:31PM -0600, David Ahern wrote:
> On 3/14/14, 3:31 PM, Andi Kleen wrote:
> >@@ -374,6 +376,8 @@ LIB_OBJS += $(OUTPUT)util/stat.o
> > LIB_OBJS += $(OUTPUT)util/record.o
> > LIB_OBJS += $(OUTPUT)util/srcline.o
> > LIB_OBJS += $(OUTPUT)util/data.o
> >+LIB_OBJS += $(OUTPUT)util/jsmn.o
> >+LIB_OBJS += $(OUTPUT)util/json.o
> >
> > LIB_OBJS += $(OUTPUT)ui/setup.o
> > LIB_OBJS += $(OUTPUT)ui/helpline.o
> >
>
> CONFIG driven? Allow a user to omit this.
Why? It has no external dependencies. AFAIK that's the only reason for configs.
(unless you count the commands used by the shell script, but the basic parser
works fine even without the script)
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists