linux-kernel - Re: [PATCH 04/15] iio: adc: at91_adc: Add support for touchscreens without TSMR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140316191639.GJ3106@piout.net>
Date:	Sun, 16 Mar 2014 20:16:39 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-iio@...r.kernel.org, linux-input@...r.kernel.org,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Gregory Clement <gregory.clement@...e-electrons.com>
Subject: Re: [PATCH 04/15] iio: adc: at91_adc: Add support for touchscreens
 without TSMR

On 16/03/2014 at 18:16:54 +0000, Jonathan Cameron wrote :
> On 05/03/14 17:35, Alexandre Belloni wrote:
> >Old ADCs, as present on the sam9rl and the sam9g45 don't have a TSMR register
> >and the touchscreen support should be handled differently.
> >
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> One comment inline about handling of devices where the platform data doesn't
> include the touchscreen type.  I'd expect zero to be the current default
> rather than NONE...
> >diff --git a/include/linux/platform_data/at91_adc.h b/include/linux/platform_data/at91_adc.h
> >index fcf73879dbfe..7819fc787731 100644
> >--- a/include/linux/platform_data/at91_adc.h
> >+++ b/include/linux/platform_data/at91_adc.h
> >@@ -7,6 +7,12 @@
> >  #ifndef _AT91_ADC_H_
> >  #define _AT91_ADC_H_
> >
> >+enum atmel_adc_ts_type {
> This means that the default for existing touch screens (where the platform
> data won't include setting this value) will be none.  Is that correct?
> >+	ATMEL_ADC_TOUCHSCREEN_NONE = 0,
> >+	ATMEL_ADC_TOUCHSCREEN_4WIRE = 4,
> >+	ATMEL_ADC_TOUCHSCREEN_5WIRE = 5,
> >+};
> >+

This is actually just a snippet that I moved from at91_adc.c to
at91_adc.h. I followed the current behavior.  Until now, using the
touchscreen was only supported through device tree and touchscreen
handling was not activated unless the atmel,adc-ts-wires property is
present.  I guess this is the sane way to go because when you use the
touchscreen, you lose the triggers.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/