linux-kernel - Re: [PATCH] Staging: gdm724x: gdm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Mar 2014 12:21:34 -0700
From:	Joe Perches <joe@...ches.com>
To:	Daniel Ngu <daniel.dy.ngu@...il.com>
Cc:	Jonathan Kim <jonathankim@...semi.com>,
	Dean ahn <deanahn@...semi.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: gdm724x: gdm_lte.h: fixed coding style

On Mon, 2014-03-17 at 08:18 +1300, Daniel Ngu wrote:
> Missing space after return type

Not really.

> diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h
[]
> @@ -56,7 +56,7 @@ struct phy_dev {
>  			int (*cb)(void *cb_data, void *data, int len,
>  				  int context),
>  			void *cb_data, int context);
> -	struct gdm_endian *(*get_endian)(void *priv_dev);
> +	struct gdm_endian * (*get_endian)(void *priv_dev);

That one was a defect in checkpatch that was
corrected in -next by:

commit 93ca9441419b0bfbf96243e01f39b5a80565215e
Author: Joe Perches <joe@...ches.com>
Date:   Thu Mar 6 11:02:08 2014 +1100

    checkpatch: don't warn on some function pointer return styles
    
    Checks for some function pointer return styles are too strict.  Fix them.
    
    Multiple spaces after function pointer return types are allowed.
        int  (*foo)(int bar)
    
    Spaces after function pointer returns of pointer types are not required.
        int *(*foo)(int bar)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/