linux-kernel - linux-next: ahci_platform broken build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5325AFB2.4050505@canonical.com>
Date:	Sun, 16 Mar 2014 08:05:38 -0600
From:	Tim Gardner <tim.gardner@...onical.com>
To:	Hans de Goede <hdegoede@...hat.com>, Tejun Heo <tj@...nel.org>
CC:	linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	dann frazier <dann.frazier@...onical.com>
Subject: linux-next: ahci_platform broken build

Gents  - while reviewing some patches for arm64 in Ubuntu I noticed that 
there is at least one patch sequence in linux-next that breaks the build.

156c5887948cd191417f18026aab9ce26e5a95da ahci-platform: Add support for 
devices with more then 1 clock
039ece38da45f5e6a94be3aa7611cf3634bc2461 libahci: Allow drivers to 
override start_engine

For example:

git reset --hard 156c5887948cd191417f18026aab9ce26e5a95da
echo "CONFIG_SATA_AHCI_PLATFORM=y" >> .config
make oldconfig scripts prepare
make M=drivers/ata

   WARNING: Symbol version dump /home/rtg/linux/linux-next/Module.symvers
            is missing; modules will have no dependencies and modversions.

   CC      drivers/ata/libata-core.o
   CC      drivers/ata/libata-scsi.o
   CC      drivers/ata/libata-eh.o
   CC      drivers/ata/libata-transport.o
   CC      drivers/ata/libata-sff.o
   CC      drivers/ata/libata-pmp.o
   CC      drivers/ata/libata-acpi.o
   LD      drivers/ata/libata.o
   CC      drivers/ata/ahci.o
   CC      drivers/ata/libahci.o
   CC      drivers/ata/ahci_platform.o
drivers/ata/ahci_platform.c: In function ‘ahci_probe’:
drivers/ata/ahci_platform.c:209:2: error: implicit declaration of 
function ‘ahci_enable_clks’ [-Werror=implicit-function-declaration]
drivers/ata/ahci_platform.c:293:2: error: implicit declaration of 
function ‘ahci_disable_clks’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[1]: *** [drivers/ata/ahci_platform.o] Error 1
make: *** [_module_drivers/ata] Error 2

The compile problem is then fixed in 
96a01ba52c60fdd74dd6e8cf06645d06515b1396 (ahci-platform: Add enable_ / 
disable_resources helper functions) which is not really kosher.

It seems like you ought to fix this before the 3.15 merge window opens.

rtg
-- 
Tim Gardner tim.gardner@...onical.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/