linux-kernel - Re: [PATCH] xen/grant-table: Refactor gnttab_[un]map_refs to avoid m2p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1403161631580.30819@kaball.uk.xensource.com>
Date:	Sun, 16 Mar 2014 16:32:34 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	David Vrabel <david.vrabel@...rix.com>
CC:	Zoltan Kiss <zoltan.kiss@...rix.com>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Russell King <linux@....linux.org.uk>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Matt Wilson <msw@...ux.com>,
	Anthony Liguori <aliguori@...zon.com>,
	Roger Pau Monné <roger.pau@...rix.com>,
	<x86@...nel.org>, <xen-devel@...ts.xenproject.org>,
	<virtualization@...ts.linux-foundation.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen/grant-table: Refactor gnttab_[un]map_refs to avoid
 m2p_override

On Mon, 10 Mar 2014, David Vrabel wrote:
> On 27/02/14 15:55, Zoltan Kiss wrote:
> > (This is a continuation of "[PATCH v9] xen/grant-table: Avoid m2p_override
> > during mapping")
> > 
> > The grant mapping API does m2p_override unnecessarily: only gntdev needs it,
> > for blkback and future netback patches it just cause a lock contention, as
> > those pages never go to userspace. Therefore this series does the following:
> > - the bulk of the original function (everything after the mapping hypercall)
> >   is moved to arch-dependent set/clear_foreign_p2m_mapping
> > - the "if (xen_feature(XENFEAT_auto_translated_physmap))" brach goes to ARM
> > - therefore the ARM function could be much smaller, the m2p_override stubs
> >   could be also removed
> > - on x86 the set_phys_to_machine calls were moved up to this new funcion
> >   from m2p_override functions
> > - and m2p_override functions are only called when there is a kmap_ops param
> > 
> > It also removes a stray space from arch/x86/include/asm/xen/page.h.
> 
> Applied to devel/for-linus-3.15.

The patch breaks the ARM build:

arch/arm/xen/p2m.c:152:1: error: expected identifier or '(' before '{' token
 {
 ^
arch/arm/xen/p2m.c:169:1: error: expected identifier or '(' before '{' token
 {
 ^

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/