linux-kernel - Re: [PATCHSET 0/9] perf tools: Update on filtered entries' percentage output (v7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r461s117.fsf@sejong.aot.lge.com>
Date:	Mon, 17 Mar 2014 17:05:24 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCHSET 0/9] perf tools: Update on filtered entries' percentage output (v7)

Ping!

On Mon, 10 Mar 2014 16:43:51 +0900, Namhyung Kim wrote:
> Hello,
>
> I added --percentage option to perf report to control display of
> percentage of filtered entries.
>
>  usage: perf report [<options>]
>
>         --percentage <relative|absolute>
>                           how to display percentage of filtered entries
>
> "relative" means it's relative to filtered entries only so that the
> sum of shown entries will be always 100%.  "absolute" means it retains
> original value before and after the filter applied.  In patch 9/9, I
> made the "absolute" as default since it makes more sense IMHO.
>     
>       $ perf report -s comm
>       # Overhead       Command
>       # ........  ............
>       #
>           74.19%           cc1
>            7.61%           gcc
>            6.11%            as
>            4.35%            sh
>            4.14%          make
>            1.13%        fixdep
>       ...
>     
>       $ perf report -s comm -c cc1,gcc --percentage absolute
>       # Overhead       Command
>       # ........  ............
>       #
>           74.19%           cc1
>            7.61%           gcc
>     
>       $ perf report -s comm -c cc1,gcc --percentage relative
>       # Overhead       Command
>       # ........  ............
>       #
>           90.69%           cc1
>            9.31%           gcc
>     
> Note that it has zero effect if no filter was applied.
>
>  * changes in v7:
>   - rename ->nr_filtered_* to ->nr_non_filtered_* (Arnaldo)
>   - remove an unneeded alignment change (Arnaldo)
>
>  * changes in v6:
>   - fix a bug in --stdio group report
>   - reuse __hpp__fmt() function in TUI/GTK
>   - add Acked-by from Jiri
>
>  * changes in v5:
>   - fix 0 samples in relative percent output (Jiri)
>   - factor hists__total_period function (Jiri)
>   - share config parsing code with option parser (Jiri)
>
>  * changes in v4:
>   - support perf top and perf diff also  (Jiri)
>   - add HIST_FILTER__HOST/GUEST  (Jiri)
>   - retain both of filtered and total stats  (Arnaldo)
>   - add 'F' hotkey on TUI  (Jiri)
>   - rename config variable to have "hist." prefix
>
>
> You can get this on the 'perf/percentage-v7' branch in my tree
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> Any comments are welcome, thanks
> Namhyung
>
>
> Namhyung Kim (9):
>   perf tools: Pass evsel to hpp->header/width functions explicitly
>   perf tools: Count periods of filtered entries separately
>   perf hists: Add support for showing relative percentage
>   perf report: Add --percentage option
>   perf top: Add --percentage option
>   perf diff: Add --percentage option
>   perf tools: Add hist.percentage config option
>   perf ui/tui: Add 'F' hotkey to toggle percentage output
>   perf tools: Show absolute percentage by default
>
>  tools/perf/Documentation/perf-diff.txt   | 21 ++++++++--
>  tools/perf/Documentation/perf-report.txt | 24 ++++++++---
>  tools/perf/Documentation/perf-top.txt    | 18 +++++++--
>  tools/perf/builtin-diff.c                | 39 ++++++++++++------
>  tools/perf/builtin-report.c              | 24 +++++++++--
>  tools/perf/builtin-top.c                 |  2 +
>  tools/perf/ui/browsers/hists.c           | 39 ++++++++++++++----
>  tools/perf/ui/gtk/hists.c                | 14 +++----
>  tools/perf/ui/hist.c                     | 32 +++++++--------
>  tools/perf/ui/stdio/hist.c               |  5 +--
>  tools/perf/util/config.c                 |  4 ++
>  tools/perf/util/event.c                  | 22 +++++------
>  tools/perf/util/hist.c                   | 68 ++++++++++++++++++++++----------
>  tools/perf/util/hist.h                   | 25 +++++++++++-
>  tools/perf/util/symbol.h                 |  5 ++-
>  15 files changed, 242 insertions(+), 100 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/