linux-kernel - Re: [PATCH] proc: show mnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140317115013.GA26250@moon>
Date:	Mon, 17 Mar 2014 15:50:13 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Pavel Emelyanov <xemul@...allels.com>
Cc:	Andrey Vagin <avagin@...nvz.org>, linux-kernel@...r.kernel.org,
	criu@...nvz.org, Al Viro <viro@...iv.linux.org.uk>,
	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] proc: show mnt_id in fdinfo files

On Mon, Mar 17, 2014 at 03:30:26PM +0400, Pavel Emelyanov wrote:
> On 03/17/2014 02:39 PM, Andrey Vagin wrote:
> > Currently we don't have a way how to determing from which mount point
> > file has been opened. This information is required for proper dumping
> > and restoring file descriptos due to presence of mount namespaces. It's
> > possible, that two file descriptors are opened using the same paths, but
> > one fd references mount point from one namespace while the other fd --
> > from other namespace.
> > 
> > Cc: Al Viro <viro@...iv.linux.org.uk>
> > Cc: Oleg Nesterov <oleg@...hat.com>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Cyrill Gorcunov <gorcunov@...nvz.org>
> > Cc: Pavel Emelyanov <xemul@...allels.com>
> > Signed-off-by: Andrey Vagin <avagin@...nvz.org>
> 
> These IDs are already shown in the /proc/$pid/mountinfo, and for some FSs
> can be obtained via path_to_handle_at(), so this patch just makes it work
> for any FS and speeds things up.
> 
> Acked-by: Pavel Emelyanov <xemul@...allels.com>

I think Documentation/filesystems/proc.txt should be updated on top.
Other than that

Reviewed-by: Cyrill Gorcunov <gorcunov@...nvz.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/