linux-kernel - Re: race in audit_log_untrusted_string for task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4829575.y6dA3xFjkS@x2>
Date:	Mon, 17 Mar 2014 09:01:45 -0400
From:	Steve Grubb <sgrubb@...hat.com>
To:	Richard Guy Briggs <rgb@...hat.com>
Cc:	linux-audit@...hat.com, LKML <linux-kernel@...r.kernel.org>,
	Eric Paris <eparis@...hat.com>
Subject: Re: race in audit_log_untrusted_string for task_struct::comm

On Saturday, March 15, 2014 07:28:46 PM Richard Guy Briggs wrote:
> I'm inclined to go get_task_comm() in all 5 locations, but if we care
> more about locking overhead, I'll switch to memcpy().
> 
> Steve, do we care about the integrity of the comm field?

In the case of interpreters, its about the only thing we know about the 
application being executed. For example, a shell script will have exe=/bin/sh, 
so comm= is our only clue.

-Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/