linux-kernel - Re: [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53272A53.8090605@redhat.com>
Date:	Mon, 17 Mar 2014 18:01:07 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	Igor Mammedov <imammedo@...hat.com>,
	linux-kernel@...r.kernel.org
CC:	gleb@...nel.org, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, kvm@...r.kernel.org
Subject: Re: [PATCH 0/2] KVM: x86 emulator: emulate MOVAPS and MOVAPD SSE
 instructions

Il 17/03/2014 16:16, H. Peter Anvin ha scritto:
> After seeing the sheer number of one-off additions, I'm wondering if going through the opcode map systematically and see what is still missing might not be a bad idea.

Memory access instructions always need emulation, but there aren't that 
many left.  There are some, such as MOVUPS/MOVUPD.

However, this is not the only use of emulation.  The problem stems from 
pre-Westmere Intel chips that didn't have unrestricted mode 
virtualization.  For these chips, you need to emulate all instructions 
that might be used in protected mode transitions and also, possibly, in 
big real mode.  In practice you will rarely see big real mode (the main 
exception is option ROMs, due to PMM), still every OS likes to do 
something different in their protected mode transitions so this is the 
source of most one-off additions that you have seen.

Until around 3.6, KVM used to transform big real mode into a "good" real 
mode that the processor would like, while breaking completely in big 
real mode; this is now emulate_invalid_guest_state=N.  Nowadays, it uses 
emulation, which is emulate_invalid_guest_state=Y.  As you can imagine 
it's quite slow (though some performance can certainly be scraped off 
the emulator).

If CS and possibly SS are valid real mode selectors, it should be 
possible to run big real mode at almost-full speed, taking exits only 
for memory accesses via other segment registers.  It is on my todo list, 
but not very high.  Depending on the exit overhead, it may be a better 
idea to revert the emulate_invalid_guest_state default to N and let 
people who care about big real mode specify Y.

Paolo

> On March 17, 2014 2:30:43 AM PDT, Paolo Bonzini <pbonzini@...hat.com> wrote:
>> Il 15/03/2014 23:42, H. Peter Anvin ha scritto:
>>> Stupid question... what instructions do NOT need emulsion in KVM? It
>> would seem that at least anything that touches memory would?
>>
>> Yes, indeed.  Anything that touches memory can be used on MMIO and then
>>
>> needs emulation.
>>
>> Paolo
>>
>>> On March 15, 2014 1:01:58 PM PDT, Igor Mammedov <imammedo@...hat.com>
>> wrote:
>>>> MS HCK test fails on 32-bit Windows 8.1 due to missing MOVAPS
>>>> instruction emulation, this series adds it and while at it,
>>>> it adds emulation of MOVAPD which is trivial to implement on
>>>> top of MOVAPS.
>>>>
>>>> Igor Mammedov (2):
>>>>  KVM: x86 emulator: emulate MOVAPS
>>>>  KVM: x86 emulator: emulate MOVAPD
>>>>
>>>> arch/x86/kvm/emulate.c | 8 +++++++-
>>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/