linux-kernel - Re: [PATCH] SPI: Add driver for Cadence SPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Mar 2014 18:14:40 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Josh Cartwright <joshc@...eaurora.org>
Cc:	Harini Katakam <harinik@...inx.com>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rob@...dley.net, grant.likely@...aro.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	michals@...inx.com
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller

On Mon, Mar 17, 2014 at 12:59:11PM -0500, Josh Cartwright wrote:
> On Mon, Mar 17, 2014 at 05:30:17PM +0000, Mark Brown wrote:
> > On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:

> > > +static int __maybe_unused cdns_spi_suspend(struct device *dev)
> > > +{

> > This needs to call spi_master_suspend() as well (and similarly on
> > resume).

> I'm not that familiar with the SPI core, but this seems like an
> inversion.  Is there a reason why the SPI master class doesn't implement
> suspend/resume() callbacks which handle stopping/starting the queue
> automatically for all masters?

This is for users of an optional feature of the infrastructure.  We
probably should just call it anyway since it does have checks for the
feature being used (but given all the open coding around this stuff I'd
need to verify that the class callbacks would reliably get called).

In any case that's not happening now and the driver as it stands is
buggy since it's trampling all over the hardware without syncing with
anything that isn't ongoing.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)